Bug 87131

Summary: Web Inspector: HeapSnapshot: speedUp buildAggregates
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Ilya Tikhonovsky 2012-05-22 07:34:23 PDT 
engine specific optimization changes. V8 can't inline getters and optimize for(i in object) loops.
I can do this because JSC doesn't have support for HeapProfiler.

RESULT heap-snapshot: _buildAggregates= 1509 ms
RESULT heap-snapshot: _calculateClassesRetainedSize= 1886 ms

vs

RESULT heap-snapshot: _buildAggregates= 665 ms
RESULT heap-snapshot: _calculateClassesRetainedSize= 1293 ms
Comment 1 Ilya Tikhonovsky 2012-05-22 07:38:57 PDT 
Created attachment 143298 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-05-22 07:47:53 PDT 
Committed r117973: <http://trac.webkit.org/changeset/117973>