Bug 87131

Summary:

Web Inspector: HeapSnapshot: speedUp buildAggregates

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2012-05-22 07:34:23 PDT

engine specific optimization changes. V8 can't inline getters and optimize for(i in object) loops. I can do this because JSC doesn't have support for HeapProfiler. RESULT heap-snapshot: _buildAggregates= 1509 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 1886 ms vs RESULT heap-snapshot: _buildAggregates= 665 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 1293 ms

Attachments
Patch (4.08 KB, patch) 2012-05-22 07:38 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-05-22 07:38:57 PDT

Created attachment 143298 [details] Patch

Ilya Tikhonovsky

Comment 2 2012-05-22 07:47:53 PDT

Committed r117973: <http://trac.webkit.org/changeset/117973>

Note You need to log in before you can comment on or make changes to this bug.