Summary: | Remove getPropertyShorthand from the web exposed API. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ahmad.saleem792, apavlov, ap, bburg, bfulgham, darin, gsnedders, hyatt, macpherson, mjs, pfeldman, rniwa, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=217625 https://bugs.webkit.org/show_bug.cgi?id=247498 |
||||||||
Bug Depends on: | 98916 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexis Menard (darktears)
2012-05-22 06:47:49 PDT
Created attachment 143297 [details]
Patch
Comment on attachment 143297 [details] Patch Attachment 143297 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12764011 Created attachment 143303 [details]
Patch
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API. Comment on attachment 143303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143303&action=review > Source/WebCore/bindings/objc/PublicDOMInterfaces.h:-981 > -- (NSString *)getPropertyShorthand:(NSString *)propertyName AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER; This is public API. It should stay, removing it is binary incompatible. If we wish to remove it we should mark it as deprecated for one release. I saw you guys branched for Safari, is there a way to mark it deprecated there and remove it here in trunk? I don't how work the releases inside Apple but that's a random thought. It should be deprecated in trunk. Assuming Alexis is no longer working on this after eight years, so unassigning. I believe this exists for the sake of Web Inspector, so Brian probably cares. This still exist: https://github.com/WebKit/WebKit/blob/b336a53b180ca88e40fef99e7f0a0779bd3d5986/Source/WebCore/css/CSSStyleDeclaration.idl#L42 Is it removed from all browsers? (Just for my learning). Thanks! Pull request: https://github.com/WebKit/WebKit/pull/6456 Committed 256636@main (80c7a3df3ee1): <https://commits.webkit.org/256636@main> Reviewed commits have been landed. Closing PR #6456 and removing active labels. |