Bug 87120

Summary: Web Inspector: annotate InjectedScriptSource.js for closure compiler
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: aandrey, alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Yury Semikhatsky 2012-05-22 05:30:48 PDT 
As Andrey Adaikin pointed out there is call of undefined function this._isPrimitiveValue in InjectedScript.wrapObject. Errors like this can be easily caught with the compiler.
Comment 1 Yury Semikhatsky 2012-05-22 05:40:24 PDT 
Created attachment 143284 [details]
Patch
Comment 2 Pavel Feldman 2012-05-22 05:46:18 PDT 
Comment on attachment 143284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143284&action=review

> Source/WebCore/inspector/InjectedScriptExterns.js:40
> +InjectedScriptHost.prototype.storageId = function(object) {}

{ }

> Source/WebCore/inspector/compile-injected-script.sh:32
> +java -jar ~/closure/compiler.jar\

could you merge it with the main compiler script instead?
Comment 3 Yury Semikhatsky 2012-05-22 05:56:52 PDT 
(In reply to comment #2)
> (From update of attachment 143284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143284&action=review
> 
> > Source/WebCore/inspector/InjectedScriptExterns.js:40
> > +InjectedScriptHost.prototype.storageId = function(object) {}
> 
> { }
> 
Done.

> > Source/WebCore/inspector/compile-injected-script.sh:32
> > +java -jar ~/closure/compiler.jar\
> 
> could you merge it with the main compiler script instead?
Done.
Comment 4 Yury Semikhatsky 2012-05-22 06:06:33 PDT 
Committed r117961: <http://trac.webkit.org/changeset/117961>