Bug 87088

Summary: Disable private names by default in WebCore
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, mrobinson, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ggaren: review+

Gavin Barraclough
Reported 2012-05-21 23:44:07 PDT
r117859 introduced a preliminary implementation of ES6-like private name objects to JSC. These are probably not yet ready to be web-facing, so disabling by default in WebCore. Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
Attachments
Fix (28.89 KB, patch)
2012-05-22 00:09 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-05-22 00:09:47 PDT
Created attachment 143206 [details] Fix
Geoffrey Garen
Comment 2 2012-05-22 11:41:29 PDT
Comment on attachment 143206 [details] Fix r=me
Gavin Barraclough
Comment 3 2012-05-22 12:09:54 PDT
Fixed in r118018
Csaba Osztrogonác
Comment 4 2012-05-22 23:43:47 PDT
After disabling private names, fast/js/names.html started to fail on GTK and Qt, because r118018 made the necessarry changes to be able run this test for Mac only. I skipped this test on Qt - r118130.
Note You need to log in before you can comment on or make changes to this bug.