Bug 87088

Summary:

Disable private names by default in WebCore

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, mrobinson, ossy, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	ggaren: review+

Description Gavin Barraclough 2012-05-21 23:44:07 PDT

r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.  These are probably not yet ready to be web-facing, so disabling by default in WebCore.
Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.

Comment 1 Gavin Barraclough 2012-05-22 00:09:47 PDT

Created attachment 143206 [details]
Fix

Comment 2 Geoffrey Garen 2012-05-22 11:41:29 PDT

Comment on attachment 143206 [details]
Fix

r=me

Comment 3 Gavin Barraclough 2012-05-22 12:09:54 PDT

Fixed in r118018

Comment 4 Csaba Osztrogonác 2012-05-22 23:43:47 PDT

After disabling private names, fast/js/names.html started to fail on GTK and Qt, because r118018 made the necessarry changes to be able run this test for Mac only. 

I skipped this test on Qt - r118130.