Bug 87053

Summary: [GTK] [WebKit2] Add an API to enable and disable composited layer indicators
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, cgarcia, dglazkov, gustavo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86037    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch with unit test and doc fix none

Description Martin Robinson 2012-05-21 15:34:33 PDT 
WebKit exposes a page setting to enable and disable composited layer borders for debugging issues with accelerated compositing. It would be useful to expose this setting so that Epiphany can use it.
Comment 1 Martin Robinson 2012-05-21 16:33:41 PDT 
Created attachment 143132 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-21 16:36:00 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2012-05-21 23:19:59 PDT 
Comment on attachment 143132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143132&action=review

Looks good! Please add a test case to the WebKitSettings unit test too.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:919
> +     * WebKitSettings:draw-compositing-indicators

Missing trailing : there
Comment 4 WebKit Review Bot 2012-05-21 23:48:29 PDT 
Comment on attachment 143132 [details]
Patch

Attachment 143132 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12748323
Comment 5 Martin Robinson 2012-05-22 11:15:52 PDT 
Created attachment 143329 [details]
Patch with unit test and doc fix
Comment 6 Carlos Garcia Campos 2012-05-22 23:34:22 PDT 
Comment on attachment 143329 [details]
Patch with unit test and doc fix

LGTM!
Comment 7 WebKit Review Bot 2012-05-23 09:06:20 PDT 
Comment on attachment 143329 [details]
Patch with unit test and doc fix

Clearing flags on attachment: 143329

Committed r118183: <http://trac.webkit.org/changeset/118183>
Comment 8 WebKit Review Bot 2012-05-23 09:06:25 PDT 
All reviewed patches have been landed.  Closing bug.