Bug 87040

Summary: Change RenderBlock to user RenderBox/RenderInline writing mode logic
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85824    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Emil A Eklund
Reported 2012-05-21 12:53:56 PDT
Remove unnecessary writing mode logic in RenderBlock and use the implementation in RenderBox and RenderInline instead.
Attachments
Patch (17.63 KB, patch)
2012-05-21 12:57 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.70 KB, patch)
2012-05-22 01:12 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.73 KB, patch)
2012-05-22 02:38 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-05-21 12:57:12 PDT
Created attachment 143081 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-21 16:08:11 PDT
Comment on attachment 143081 [details] Patch I might have named it "overrideStyle" instead of otherStyle. This seems OK. the usingStyle(style) pattern would be fine to.
Emil A Eklund
Comment 3 2012-05-22 01:12:31 PDT
Created attachment 143219 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-05-22 01:58:12 PDT
Comment on attachment 143219 [details] Patch for landing Rejecting attachment 143219 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: re::RenderStyle*)': Source/WebCore/rendering/RenderBox.cpp:171: error: 'otherStyle' was not declared in this scope Source/WebCore/rendering/RenderBox.cpp: In member function 'void WebCore::RenderBox::setMarginAfter(WebCore::LayoutUnit, const WebCore::RenderStyle*)': Source/WebCore/rendering/RenderBox.cpp:189: error: 'otherStyle' was not declared in this scope make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBox.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/12730937
Emil A Eklund
Comment 5 2012-05-22 02:38:43 PDT
Created attachment 143243 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-05-22 04:15:34 PDT
Comment on attachment 143243 [details] Patch for landing Clearing flags on attachment: 143243 Committed r117946: <http://trac.webkit.org/changeset/117946>
WebKit Review Bot
Comment 7 2012-05-22 04:15:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.