Change RenderBlock to user RenderBox/RenderInline writing mode logic

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Emil A Eklund]

Remove unnecessary writing mode logic in RenderBlock and use the implementation in RenderBox and RenderInline instead.

[Emil A Eklund]

Created attachment 143081 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 143081 [details]
Patch

I might have named it "overrideStyle" instead of otherStyle.  This seems OK.  the usingStyle(style) pattern would be fine to.

[Emil A Eklund]

Created attachment 143219 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143219 [details]
Patch for landing

Rejecting attachment 143219 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
re::RenderStyle*)':
Source/WebCore/rendering/RenderBox.cpp:171: error: 'otherStyle' was not declared in this scope
Source/WebCore/rendering/RenderBox.cpp: In member function 'void WebCore::RenderBox::setMarginAfter(WebCore::LayoutUnit, const WebCore::RenderStyle*)':
Source/WebCore/rendering/RenderBox.cpp:189: error: 'otherStyle' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/RenderBox.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12730937

[Emil A Eklund]

Created attachment 143243 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143243 [details]
Patch for landing

Clearing flags on attachment: 143243

Committed r117946: <http://trac.webkit.org/changeset/117946>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.