Bug 87027

Summary: Cleanup of Calls to operationStrCat and operationNewArray and Use Constructor after r117729
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated Patch with create() addition oliver: review+

Michael Saboff
Reported 2012-05-21 10:13:06 PDT
The DFS JIT code that generates calls to operationStrCat and operationNewArray should directly provide the data buffer instead of providing the ScratchBuffer pointer. This would eliminate the need for operationStrCat and operationNewArray from having to call dataBuffer() on the ScratchBuffer object.
Attachments
Patch (3.98 KB, patch)
2012-05-21 10:42 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated Patch with create() addition (5.65 KB, patch)
2012-05-21 17:06 PDT, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-05-21 10:42:43 PDT
Created attachment 143057 [details] Patch
Michael Saboff
Comment 2 2012-05-21 16:57:10 PDT
Comment #15 from https://bugs.webkit.org/show_bug.cgi?id=86553 after the change set landed suggests that we should add a create() method and use the constructor for ScratchBuffer.
Michael Saboff
Comment 3 2012-05-21 17:06:57 PDT
Created attachment 143140 [details] Updated Patch with create() addition
Michael Saboff
Comment 4 2012-05-21 17:48:47 PDT
Committed r117860: <http://trac.webkit.org/changeset/117860>
Note You need to log in before you can comment on or make changes to this bug.