Bug 87022

Summary: Web Inspector: switch buildDominatedNodes function to front-end calculated _dominatorsTree
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87089    
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-05-21 08:40:00 PDT
%subj% RESULT heap-snapshot: _buildDominatedNodes= 135 ms vs RESULT heap-snapshot: _buildDominatedNodes= 31 ms
Attachments
Patch (7.47 KB, patch)
2012-05-21 08:47 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-21 08:47:52 PDT
Created attachment 143043 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-21 08:51:14 PDT
Comment on attachment 143043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143043&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:-722 > - if (this._dominatorOffset !== -1) // For tests where we may not have dominator field. Please make sure that it doesn't break tests.
Ilya Tikhonovsky
Comment 3 2012-05-21 09:01:25 PDT
Committed r117786: <http://trac.webkit.org/changeset/117786>
Note You need to log in before you can comment on or make changes to this bug.