| Summary: | QtWebkit: handle german umlauts in keyIdentifierForQtKeyCode() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Holger Kaelberer <hk> | ||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | allan.jensen, bruno.abinader, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
Comment on attachment 142991 [details]
handle german umlauts in keyIdentifierForQtKeyCode()
Missing ChangeLog comments. There is a tool that helps a lot on that (Tools/Scripts/prepare-changelog).
Created attachment 148994 [details]
corresponding changelog entry
Corresponding Changelog entry patch. Used a git checkout this time because svn co ended up with an error.
Attachment 148994 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog']" exit_code: 1
Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 149002 [details]
updated changelog patch
updated changelog patch
The Qt port no longer exists in webkit.org. |
Created attachment 142991 [details] handle german umlauts in keyIdentifierForQtKeyCode() Currently german umlauts are not mapped correctly to keycodes in key events in QtWebkit classes (keycode=0). Tested on linux. The attached patch fixes this issue for us by adding the missing Qt::Key_* cases in keyIdentifierForQtKeyCode(). Thanks, Holger