Bug 86988

Summary:

[EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, feature-media-reviews, gouache95, gyuyoung.kim, lucas.de.marchi, macpherson, menard, rakuco, s.choi, tmpsantos, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gyuyoung Kim 2012-05-20 23:17:44 PDT

In order to support fullscreen feature, EFL port needs to have new css file for fullscreen media control UI. Initial mediaControlsEflFullscreen.css of this patch is just simple implementation which doesn't influence on existing layout test result first. In future, this css file should be implemented together with updated expected result.

Comment 1 Gyuyoung Kim 2012-05-20 23:24:32 PDT

Created attachment 142949 [details]
Patch

Comment 2 WebKit Review Bot 2012-05-21 20:29:59 PDT

Comment on attachment 142949 [details]
Patch

Clearing flags on attachment: 142949

Committed r117890: <http://trac.webkit.org/changeset/117890>

Comment 3 WebKit Review Bot 2012-05-21 20:30:05 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Thiago Marcos P. Santos 2012-05-22 03:30:46 PDT

These tests are flaky after this patch:

media/video-controls-rendering.html = TEXT PASS
media/video-display-toggle.html = TEXT PASS
media/video-empty-source.html = TEXT PASS
media/video-zoom-controls.html = TEXT PASS

Comment 5 Gyuyoung Kim 2012-05-22 03:46:14 PDT

(In reply to comment #4)
> These tests are flaky after this patch:
> 
> media/video-controls-rendering.html = TEXT PASS
> media/video-display-toggle.html = TEXT PASS
> media/video-empty-source.html = TEXT PASS
> media/video-zoom-controls.html = TEXT PASS

I'm sorry, could you please rebaseline for those tests ?

Comment 6 Thiago Marcos P. Santos 2012-05-22 09:23:12 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > These tests are flaky after this patch:
> > 
> > media/video-controls-rendering.html = TEXT PASS
> > media/video-display-toggle.html = TEXT PASS
> > media/video-empty-source.html = TEXT PASS
> > media/video-zoom-controls.html = TEXT PASS
> 
> I'm sorry, could you please rebaseline for those tests ?

Fixed on bug 87138.