Bug 86982

Summary: [EFL] Do not enable Web Audio support by default at build time.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, dw.im, gyuyoung.kim, lucas.de.marchi, pnormand, s.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-20 20:22:51 PDT
[EFL] Do not enable Web Audio support by default at build time.
Attachments
Patch (1.66 KB, patch)
2012-05-20 20:25 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-20 20:25:44 PDT
Created attachment 142937 [details] Patch
Gyuyoung Kim
Comment 2 2012-05-21 04:30:08 PDT
Comment on attachment 142937 [details] Patch Looks fine.
Philippe Normand
Comment 3 2012-05-21 11:45:02 PDT
Comment on attachment 142937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review > ChangeLog:13 > + Since Web Audio support for the EFL port does not seem to be fully > + working yet, it is better to disable it in all cases. I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-05-21 11:57:07 PDT
(In reply to comment #3) > (From update of attachment 142937 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review > > > ChangeLog:13 > > + Since Web Audio support for the EFL port does not seem to be fully > > + working yet, it is better to disable it in all cases. > > I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187 Probably that. I tried running the webaudio/ layout tests with web audio support enabled and they did not work. Then looking at the commit which added web audio support for the EFL port I noticed this build system inconsistency.
WebKit Review Bot
Comment 5 2012-05-21 12:23:53 PDT
Comment on attachment 142937 [details] Patch Clearing flags on attachment: 142937 Committed r117807: <http://trac.webkit.org/changeset/117807>
WebKit Review Bot
Comment 6 2012-05-21 12:23:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.