Bug 86970

Summary: Move padding/margin/offset writing mode logic from RenderStyle to LengthBox
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Emil A Eklund 2012-05-20 13:30:41 PDT 
RenderStyle currently has a lot of logic for translating before/after/start/end to top/bottom/left/right for paddings, margins, borders and offsets. Move this logic to LengthBox and make paddings/margins/offsets use the same implementation.
Comment 1 Emil A Eklund 2012-05-20 13:38:29 PDT 
Created attachment 142915 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-21 16:06:25 PDT 
Comment on attachment 142915 [details]
Patch

Again, same possible perf considerations, but another huge cleanliness win.  We'll see!
Comment 3 WebKit Review Bot 2012-05-21 16:42:10 PDT 
Comment on attachment 142915 [details]
Patch

Clearing flags on attachment: 142915

Committed r117832: <http://trac.webkit.org/changeset/117832>
Comment 4 WebKit Review Bot 2012-05-21 16:42:14 PDT 
All reviewed patches have been landed.  Closing bug.