Bug 86962

Summary:

[GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKitGTK

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch v2 (fixed bug title changelog)	gustavo: review-, gustavo: commit-queue-
patch v3 (fixed case also)	none

Mikhail Pozdnyakov

Reported 2012-05-20 04:29:57 PDT

In order to be consistent with other Webkit ports GTK's LayoutTestController::setCacheModel(int cacheModel) should set WEBKIT_CACHE_MODEL_WEB_BROWSER if cacheModel is equal to 3, currently sets WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER.

Attachments
patch (1.47 KB, patch) 2012-05-20 04:37 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
patch v2 (fixed bug title changelog) (1.47 KB, patch) 2012-05-20 04:43 PDT, Mikhail Pozdnyakov	gustavo: review- gustavo: commit-queue-	Details Formatted Diff Diff
patch v3 (fixed case also) (1.48 KB, patch) 2012-05-22 00:27 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2012-05-20 04:37:22 PDT

Created attachment 142897 [details] patch

Mikhail Pozdnyakov

Comment 2 2012-05-20 04:43:14 PDT

Created attachment 142898 [details] patch v2 (fixed bug title changelog)

Gustavo Noronha (kov)

Comment 3 2012-05-21 11:51:50 PDT

Comment on attachment 142898 [details] patch v2 (fixed bug title changelog) View in context: https://bugs.webkit.org/attachment.cgi?id=142898&action=review > Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:655 > case 3: > - webkit_set_cache_model(WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER); > + webkit_set_cache_model(WEBKIT_CACHE_MODEL_WEB_BROWSER); Your change looks right to me, but... that case should be 2 not 3, and 2 should be falling down to the ASSERT_NOT_REACHED(), so I'm wondering if this is used at all. Hah, it's not used indeed: kov@goiaba ~/s/W/LayoutTests> git grep setCacheModel fast/dom/HTMLScriptElement/nested-execution.html: layoutTestController.setCacheModel(0); // WebCacheModelDocumentViewer platform/chromium/test_expectations.txt:// This test requires LayoutTestController.setCacheModel, which we don't platform/efl/Skipped:# EFL's LayoutTestController does not implement setCacheModel platform/wk2/Skipped:# WebKitTestRunner needs layoutTestController.setCacheModel Please fix the case too.

Mikhail Pozdnyakov

Comment 4 2012-05-22 00:27:35 PDT

Created attachment 143211 [details] patch v3 (fixed case also)

Mikhail Pozdnyakov

Comment 5 2012-05-22 00:29:58 PDT

(In reply to comment #3) > Please fix the case too. Wow! I did not noticed that issue.. Thanks for review.

WebKit Review Bot

Comment 6 2012-05-22 11:17:39 PDT

Comment on attachment 143211 [details] patch v3 (fixed case also) Clearing flags on attachment: 143211 Committed r118007: <http://trac.webkit.org/changeset/118007>

WebKit Review Bot

Comment 7 2012-05-22 11:17:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.