Bug 86946

Summary: [EFL] Implement PlatformStrategies
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, gyuyoung.kim, ky0.choi, lucas.de.marchi, mariusz.g, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sudarsana Nagineni (babu)
Reported 2012-05-19 12:05:39 PDT
Add support/enable PLATFORM_STRATEGIES in the EFL port. Many ports already supports PlatformStrategies and we will need them for WebKit2. reference: https://lists.webkit.org/pipermail/webkit-dev/2010-June/013270.html
Attachments
Patch (15.29 KB, patch)
2012-05-24 08:36 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-05-24 08:36:03 PDT
Created attachment 143836 [details] Patch Turn on PLATFORM_STRATEGIES for EFL platform.
Ryuan Choi
Comment 2 2012-05-30 01:02:25 PDT
(In reply to comment #1) > Created an attachment (id=143836) [details] > Patch > > Turn on PLATFORM_STRATEGIES for EFL platform. Looks good to me.
Gyuyoung Kim
Comment 3 2012-05-30 01:12:55 PDT
Looks fine. CC'ing Mariusz.
WebKit Review Bot
Comment 4 2012-06-01 03:45:39 PDT
Comment on attachment 143836 [details] Patch Clearing flags on attachment: 143836 Committed r119208: <http://trac.webkit.org/changeset/119208>
WebKit Review Bot
Comment 5 2012-06-01 03:45:44 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-06-01 06:44:55 PDT
Comment on attachment 143836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143836&action=review > Source/WebCore/PlatformEfl.cmake:87 > + platform/PlatformStrategies.cpp One small post-mortem nitpick here is that casing matters in the sorting here, so in the future please consider that 'P' < 'n'.
KwangYong Choi
Comment 7 2012-06-14 00:01:30 PDT
*** Bug 89063 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.