Summary: | [EFL] Implement PlatformStrategies | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, gyuyoung.kim, ky0.choi, lucas.de.marchi, mariusz.g, rakuco, ryuan.choi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2012-05-19 12:05:39 PDT
Created attachment 143836 [details]
Patch
Turn on PLATFORM_STRATEGIES for EFL platform.
(In reply to comment #1) > Created an attachment (id=143836) [details] > Patch > > Turn on PLATFORM_STRATEGIES for EFL platform. Looks good to me. Looks fine. CC'ing Mariusz. Comment on attachment 143836 [details] Patch Clearing flags on attachment: 143836 Committed r119208: <http://trac.webkit.org/changeset/119208> All reviewed patches have been landed. Closing bug. Comment on attachment 143836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143836&action=review > Source/WebCore/PlatformEfl.cmake:87 > + platform/PlatformStrategies.cpp One small post-mortem nitpick here is that casing matters in the sorting here, so in the future please consider that 'P' < 'n'. |