Bug 86937

Summary:

Web Inspector: make search results view more dense

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Screenshot with patch applied.	none
Patch	none
Patch	none
[Patch] Same with closing search on panel switch	none
[IMAGE] Screenshot with patch applied including new close button.	none
Patch	none
[Patch] Same with onclose notification	yurys: review+

Pavel Feldman

Reported 2012-05-18 23:16:52 PDT

See the screenshot.

Attachments
[IMAGE] Screenshot with patch applied. (129.83 KB, image/png) 2012-05-18 23:18 PDT, Pavel Feldman	no flags	Details
Patch (6.31 KB, patch) 2012-05-18 23:23 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (7.48 KB, patch) 2012-05-19 00:55 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[Patch] Same with closing search on panel switch (8.76 KB, patch) 2012-05-19 01:37 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[IMAGE] Screenshot with patch applied including new close button. (66.93 KB, image/png) 2012-05-19 03:07 PDT, Pavel Feldman	no flags	Details
Patch (11.73 KB, patch) 2012-05-19 03:08 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[Patch] Same with onclose notification (16.23 KB, patch) 2012-05-19 06:00 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-05-18 23:18:46 PDT

Created attachment 142852 [details] [IMAGE] Screenshot with patch applied.

Pavel Feldman

Comment 2 2012-05-18 23:23:45 PDT

Created attachment 142853 [details] Patch

Pavel Feldman

Comment 3 2012-05-19 00:55:27 PDT

Created attachment 142855 [details] Patch

Pavel Feldman

Comment 4 2012-05-19 01:37:45 PDT

Created attachment 142857 [details] [Patch] Same with closing search on panel switch

Pavel Feldman

Comment 5 2012-05-19 03:07:28 PDT

Created attachment 142859 [details] [IMAGE] Screenshot with patch applied including new close button.

Pavel Feldman

Comment 6 2012-05-19 03:08:43 PDT

Created attachment 142860 [details] Patch

Pavel Feldman

Comment 7 2012-05-19 06:00:39 PDT

Created attachment 142864 [details] [Patch] Same with onclose notification

Yury Semikhatsky

Comment 8 2012-05-21 00:11:33 PDT

Comment on attachment 142864 [details] [Patch] Same with onclose notification View in context: https://bugs.webkit.org/attachment.cgi?id=142864&action=review > Source/WebCore/inspector/front-end/inspector.js:164 > + document.getElementById("main-status-bar").removeChild(this._drawerStatusBarHeader); This 5 lines are repeated twice, please extract a method.

Pavel Feldman

Comment 9 2012-05-21 01:35:54 PDT

Committed r117746: <http://trac.webkit.org/changeset/117746>

Note You need to log in before you can comment on or make changes to this bug.