Bug 86937

Summary: Web Inspector: make search results view more dense
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Screenshot with patch applied.
none
Patch
none
Patch
none
[Patch] Same with closing search on panel switch
none
[IMAGE] Screenshot with patch applied including new close button.
none
Patch
none
[Patch] Same with onclose notification yurys: review+

Description Pavel Feldman 2012-05-18 23:16:52 PDT
See the screenshot.
Comment 1 Pavel Feldman 2012-05-18 23:18:46 PDT
Created attachment 142852 [details]
[IMAGE] Screenshot with patch applied.
Comment 2 Pavel Feldman 2012-05-18 23:23:45 PDT
Created attachment 142853 [details]
Patch
Comment 3 Pavel Feldman 2012-05-19 00:55:27 PDT
Created attachment 142855 [details]
Patch
Comment 4 Pavel Feldman 2012-05-19 01:37:45 PDT
Created attachment 142857 [details]
[Patch] Same with closing search on panel switch
Comment 5 Pavel Feldman 2012-05-19 03:07:28 PDT
Created attachment 142859 [details]
[IMAGE] Screenshot with patch applied including new close button.
Comment 6 Pavel Feldman 2012-05-19 03:08:43 PDT
Created attachment 142860 [details]
Patch
Comment 7 Pavel Feldman 2012-05-19 06:00:39 PDT
Created attachment 142864 [details]
[Patch] Same with onclose notification
Comment 8 Yury Semikhatsky 2012-05-21 00:11:33 PDT
Comment on attachment 142864 [details]
[Patch] Same with onclose notification

View in context: https://bugs.webkit.org/attachment.cgi?id=142864&action=review

> Source/WebCore/inspector/front-end/inspector.js:164
> +            document.getElementById("main-status-bar").removeChild(this._drawerStatusBarHeader);

This 5 lines are repeated twice, please extract a method.
Comment 9 Pavel Feldman 2012-05-21 01:35:54 PDT
Committed r117746: <http://trac.webkit.org/changeset/117746>