Bug 86923

Summary: [Chromium-Android] Run DumpRenderTree as an apk (python part)
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, jnd, ojan, rakuco, tony, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86862    
Attachments:
Description Flags
patch
abarth: review+
patch for landing none

Xianzhu Wang
Reported 2012-05-18 16:38:48 PDT
Python part of patch for bug 86862.
Attachments
patch (27.69 KB, patch)
2012-05-18 16:54 PDT, Xianzhu Wang 		abarth: review+
DetailsFormatted DiffDiff
patch for landing (29.00 KB, patch)
2012-05-22 12:08 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-05-18 16:54:02 PDT
Created attachment 142822 [details] patch
Adam Barth
Comment 2 2012-05-20 20:53:39 PDT
Comment on attachment 142822 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=142822&action=review Ok. This is mostly a rubber stamp, but this looks plausible. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:481 > + if seconds == DRT_START_STOP_TIMEOUT_SECS: Should we use >= instead of == ?
Xianzhu Wang
Comment 3 2012-05-22 12:06:53 PDT
Comment on attachment 142822 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=142822&action=review >> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:481 >> + if seconds == DRT_START_STOP_TIMEOUT_SECS: > > Should we use >= instead of == ? Done.
Xianzhu Wang
Comment 4 2012-05-22 12:08:14 PDT
Created attachment 143347 [details] patch for landing
Adam Barth
Comment 5 2012-05-22 12:24:11 PDT
Comment on attachment 143347 [details] patch for landing If you'd like me to commit-queue+ this patch, you can mark it commit-queue?
Xianzhu Wang
Comment 6 2012-05-22 13:21:26 PDT
(In reply to comment #5) > (From update of attachment 143347 [details]) > If you'd like me to commit-queue+ this patch, you can mark it commit-queue? Thanks. I didn't mark it commit-queue? because I'm preparing the patch for landing of the related bug 86922. I'll commit them when both are ready.
Xianzhu Wang
Comment 7 2012-05-22 16:20:32 PDT
Comment on attachment 143347 [details] patch for landing commit-queue+ after commit-queue+ of bug 86922.
WebKit Review Bot
Comment 8 2012-05-22 17:40:20 PDT
Comment on attachment 143347 [details] patch for landing Clearing flags on attachment: 143347 Committed r118089: <http://trac.webkit.org/changeset/118089>
WebKit Review Bot
Comment 9 2012-05-22 17:40:30 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 10 2012-05-22 18:11:02 PDT
This appears to have broken Python tests: http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/2234/steps/webkitpy-test/logs/stdio
Adam Barth
Comment 11 2012-05-22 18:29:41 PDT
@wangxianzhu: Please run test-webkitpy before landing changes to webkitpy. Do you think you'll be able to fix this soon, or should we roll it out and try relanding it?
Xianzhu Wang
Comment 12 2012-05-22 19:00:41 PDT
I'll disable chromium_android_unittest.py first, then update the tests. Sorry I didn't see the tests in downstream.
Note You need to log in before you can comment on or make changes to this bug.