Bug 86904

Summary:

Revert to float method of selection rect alignment for line box tree

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

Layout and Rendering

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85555

Attachments:

Description	Flags
Patch	none

Description Levi Weintraub 2012-05-18 14:46:39 PDT

In r117491, we introduced a new method of alignment for the selection rect in the sub-pixel case. It turns out there is at least one case on Mac where this doesn't work with the line box tree. This patch reverts us to the float method for the line box tree, but retains the LayoutRect snapping for gap rects.

Comment 1 Levi Weintraub 2012-05-18 15:46:40 PDT

Created attachment 142802 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-05-18 15:54:08 PDT

Comment on attachment 142802 [details]
Patch

OK.

Comment 3 WebKit Review Bot 2012-05-18 16:57:43 PDT

Comment on attachment 142802 [details]
Patch

Clearing flags on attachment: 142802

Committed r117659: <http://trac.webkit.org/changeset/117659>

Comment 4 WebKit Review Bot 2012-05-18 16:57:51 PDT

All reviewed patches have been landed.  Closing bug.