Bug 86892
| Summary: | consider changing the outcome keywords in the expectations file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, kkristof, mjs, ojan, rniwa, simon.fraser, tony |
| Priority: | P2 | Keywords: | NRWT |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Pranke
the current list of outcome keywords are:
AUDIO
CRASH
FAIL
IMAGE
IMAGE+TEXT
PASS
TEXT
TIMEOUT
(I'm ignoring SLOW and REBASELINE; those are separate discussions)
To be clear, IMAGE means *just* the PNG fails to match, TEXT means *just* the .txt fails to match, and IMAGE+TEXT means both fail. IMAGE+TEXT does not mean "either is allowed to fail".
FAIL is a "legacy" keyword that is interpreted as "any of IMAGE, IMAGE+TEXT, TEXT".
It has been suggested -- :) -- that we should use different names and/or a switched to lower or mixed case for the keywords, and that perhaps some of the keywords should be consolidated and/or removed.
For the record, I'm okay with (but don't have a strong preference for) switching to lower case depending on what other changes to the syntax of the file occur. I'm not a fan of mixed-case keywords. I have not yet seen any proposals for new keywords I prefer to the existing format.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
Bug 89161 covers the casing questions (TitleCase) that were resolved in http://lists.webkit.org/pipermail/webkit-dev/2012-June/021131.html.
This bug should just focus on the naming of the keywords. See http://lists.webkit.org/pipermail/webkit-dev/2012-June/020963.html. The suggestion there is to have:
Fail
PixelOnlyFail
Pass
Timeout
Crash
Fail now encompasses the previous Audio, Image+Text and Text.
Dirk Pranke
fixed in bug 89161.