Summary: | [chromium] remove obsolete WebViewClient::startDragging version | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jochen | ||||||||
Component: | New Bugs | Assignee: | jochen | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
jochen
2012-05-18 12:53:08 PDT
Created attachment 142769 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 142769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142769&action=review > Source/WebKit/chromium/DEPS:35 > - 'chromium_rev': '136942' > + 'chromium_rev': '137932' We had trouble with rolling the chromium_rev in a previous bug. Please makes sure this compiles before landing. > Source/WebKit/chromium/public/WebViewClient.h:253 > + virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { } I'd leave the dragImageOffset name in since that's not obvious (at least to me). Created attachment 142771 [details]
Patch
Comment on attachment 142771 [details] Patch Attachment 142771 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12722897 Created attachment 142851 [details]
Patch
Comment on attachment 142851 [details] Patch Clearing flags on attachment: 142851 Committed r117678: <http://trac.webkit.org/changeset/117678> All reviewed patches have been landed. Closing bug. |