Bug 86887 - [chromium] remove obsolete WebViewClient::startDragging version
Summary: [chromium] remove obsolete WebViewClient::startDragging version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-18 12:53 PDT by jochen
Modified: 2012-05-18 23:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2012-05-18 12:57 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2012-05-18 13:08 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2012-05-18 22:45 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-05-18 12:53:08 PDT 
[chromium] remove obsolete WebViewClient::startDragging version
Comment 1 jochen 2012-05-18 12:57:37 PDT 
Created attachment 142769 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-18 13:00:39 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-05-18 13:04:12 PDT 
Comment on attachment 142769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142769&action=review

> Source/WebKit/chromium/DEPS:35
> -  'chromium_rev': '136942'
> +  'chromium_rev': '137932'

We had trouble with rolling the chromium_rev in a previous bug.  Please makes sure this compiles before landing.

> Source/WebKit/chromium/public/WebViewClient.h:253
> +    virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }

I'd leave the dragImageOffset name in since that's not obvious (at least to me).
Comment 4 jochen 2012-05-18 13:08:53 PDT 
Created attachment 142771 [details]
Patch
Comment 5 WebKit Review Bot 2012-05-18 14:05:20 PDT 
Comment on attachment 142771 [details]
Patch

Attachment 142771 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12722897
Comment 6 jochen 2012-05-18 22:45:06 PDT 
Created attachment 142851 [details]
Patch
Comment 7 WebKit Review Bot 2012-05-18 23:12:37 PDT 
Comment on attachment 142851 [details]
Patch

Clearing flags on attachment: 142851

Committed r117678: <http://trac.webkit.org/changeset/117678>
Comment 8 WebKit Review Bot 2012-05-18 23:12:42 PDT 
All reviewed patches have been landed.  Closing bug.