Bug 86887 – [chromium] remove obsolete WebViewClient::startDragging version

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] remove obsolete WebViewClient::startDragging version

Created attachment 142769 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 142769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142769&action=review

> Source/WebKit/chromium/DEPS:35
> -  'chromium_rev': '136942'
> +  'chromium_rev': '137932'

We had trouble with rolling the chromium_rev in a previous bug.  Please makes sure this compiles before landing.

> Source/WebKit/chromium/public/WebViewClient.h:253
> +    virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }

I'd leave the dragImageOffset name in since that's not obvious (at least to me).

Created attachment 142771 [details]
Patch

[WebKit Review Bot]

Comment on attachment 142771 [details]
Patch

Attachment 142771 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12722897

Created attachment 142851 [details]
Patch

[WebKit Review Bot]

Comment on attachment 142851 [details]
Patch

Clearing flags on attachment: 142851

Committed r117678: <http://trac.webkit.org/changeset/117678>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.