Bug 86877

Summary: Must set/reset pixel unpack alignment to 1 during texSubImage2D
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cmarrin, dino, gman, jamesr, jbauman, senorblanco, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87042, 87136    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2012-05-18 11:22:22 PDT
Most of WebGLRenderingContext's texImage2D and texSubImage2D code paths, in particular those taking DOM elements and ImageData, have to pack the texture data into a temporary buffer before uploading. This temporary buffer is tightly packed, so the UNPACK_ALIGNMENT pixel store parameter has to be set to 1 during the upload. This was done for texImage2D a long time ago but is missing in the texSubImage2D code paths.
Attachments
Patch (63.76 KB, patch)
2012-05-21 14:27 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2012-05-21 14:27:00 PDT
Created attachment 143095 [details] Patch
James Robinson
Comment 2 2012-05-21 14:32:24 PDT
Comment on attachment 143095 [details] Patch R=me. C++ changes look fine, I haven't carefully looked at the layout tests but since they are imports I'm assuming they are fine.
WebKit Review Bot
Comment 3 2012-05-21 23:57:21 PDT
Comment on attachment 143095 [details] Patch Clearing flags on attachment: 143095 Committed r117918: <http://trac.webkit.org/changeset/117918>
WebKit Review Bot
Comment 4 2012-05-21 23:57:31 PDT
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 5 2012-05-22 08:56:28 PDT
(In reply to comment #2) > (From update of attachment 143095 [details]) > R=me. C++ changes look fine, I haven't carefully looked at the layout tests but since they are imports I'm assuming they are fine. They weren't. This started 4 failures on Mac bots http://build.webkit.org/results/Lion%20Release%20(Tests)/r117918%20(8526)/results.html
Note You need to log in before you can comment on or make changes to this bug.