Bug 86874

Summary: IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: WebCore Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2012-05-18 11:12:11 PDT
The function is non-standard; while proposed, and with some interest from other implementers, it will not be in V1 of the IDB spec. While the overall IDB implementation in WebKit is currently prefixed, when we drop the prefix we do not want to introduce a non-prefixed non-standard member. The patch probably as simple as: - [CallWith=ScriptExecutionContext] IDBRequest getDatabaseNames(); + [CallWith=ScriptExecutionContext, ImplementedAs=continueFunction] IDBRequest getDatabaseNames(); ... plus test updates.
Attachments
Patch (6.21 KB, patch)
2012-05-18 13:23 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (5.76 KB, patch)
2012-06-04 11:22 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-05-18 13:23:50 PDT
Created attachment 142775 [details] Patch
Joshua Bell
Comment 2 2012-05-18 13:41:31 PDT
NOTE: Check (casually) to see if anyone is using this before landing.
Joshua Bell
Comment 3 2012-06-04 11:22:33 PDT
Created attachment 145610 [details] Patch
Joshua Bell
Comment 4 2012-06-04 11:23:51 PDT
abarth@: r?
Joshua Bell
Comment 5 2012-06-06 10:24:19 PDT
I probably don't need abarth@ to bless this one. tony@ or ojan@?
WebKit Review Bot
Comment 6 2012-06-06 12:00:25 PDT
Comment on attachment 145610 [details] Patch Clearing flags on attachment: 145610 Committed r119603: <http://trac.webkit.org/changeset/119603>
WebKit Review Bot
Comment 7 2012-06-06 12:00:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.