Summary: | [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, gbillock, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 85364 | ||||||||||
Bug Blocks: | 86868 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-05-18 10:10:39 PDT
Created attachment 143563 [details]
Patch
Comment on attachment 143563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143563&action=review The EFL part looks OK, I'd prefer someone else to comment on the cross-port sendWebIntentResponseCallback. > Tools/DumpRenderTree/LayoutTestController.cpp:2011 > + if (argumentCount== 1) { Nit: missing a space before '=='. Created attachment 143567 [details]
Patch
Fix style nit. Thanks Rakuco.
Comment on attachment 143567 [details]
Patch
ok
Comment on attachment 143567 [details] Patch Rejecting attachment 143567 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: .h patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp patching file Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp patching file Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm patching file Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp patching file Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12780324 Created attachment 143731 [details]
Patch for landing
Comment on attachment 143731 [details] Patch for landing Clearing flags on attachment: 143731 Committed r118331: <http://trac.webkit.org/changeset/118331> All reviewed patches have been landed. Closing bug. |