Bug 86865

Summary: [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gbillock, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85364    
Bug Blocks: 86868    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2012-05-18 10:02:53 PDT 
EFL's LayoutTestController needs to implement deliverWebIntent which is required by the following test case:
  webintents/web-intents-delivery.html
Comment 1 Chris Dumez 2012-06-01 03:24:57 PDT 
Created attachment 145258 [details]
Patch
Comment 2 Chris Dumez 2012-06-01 03:34:30 PDT 
Created attachment 145259 [details]
Patch

Add missing documentation.
Comment 3 Gyuyoung Kim 2012-06-01 03:43:24 PDT 
Comment on attachment 145259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145259&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:753
> +void ewk_frame_intent_deliver(Evas_Object *ewkFrame, Ewk_Intent *ewkIntent)

Move '*' operator to data type side.

By the way, it looks this is to get smartData object form ewkFrame object. Is it better to add const keyword ?

> Source/WebKit/efl/ewk/ewk_frame.h:711
> +EAPI void ewk_frame_intent_deliver(Evas_Object *o, Ewk_Intent *ewkIntent);

Change ewkIntent with ewk_intent.
Comment 4 Chris Dumez 2012-06-01 03:51:29 PDT 
Created attachment 145265 [details]
Patch

Thanks for catching this Gyuyoung.
Comment 5 WebKit Review Bot 2012-06-01 08:49:20 PDT 
Comment on attachment 145265 [details]
Patch

Clearing flags on attachment: 145265

Committed r119237: <http://trac.webkit.org/changeset/119237>
Comment 6 WebKit Review Bot 2012-06-01 08:49:25 PDT 
All reviewed patches have been landed.  Closing bug.