Bug 86857

Summary: [Qt] Add UI tests for fit-to-view
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit QtAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, menard, ossy, webkit.review.bot, zalan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87236    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kenneth Rohde Christiansen
Reported 2012-05-18 08:38:40 PDT
SSIA
Attachments
Patch (8.30 KB, patch)
2012-05-18 08:52 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-05-18 08:52:22 PDT
Created attachment 142724 [details] Patch
WebKit Review Bot
Comment 2 2012-05-22 03:44:39 PDT
Comment on attachment 142724 [details] Patch Clearing flags on attachment: 142724 Committed r117942: <http://trac.webkit.org/changeset/117942>
WebKit Review Bot
Comment 3 2012-05-22 03:44:45 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2012-05-23 02:18:05 PDT
FYI - the newly added test fails with the following error message: FAIL! : qmltests::FitToView::test_basic() Compared values are not the same Actual (): 0.5 Expected (): 1 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml(96)]
Csaba Osztrogonác
Comment 5 2012-05-23 02:21:03 PDT
I filed a new bug report to fix this bug (because reopening bugs isn't allowed.) - https://bugs.webkit.org/show_bug.cgi?id=87236
Note You need to log in before you can comment on or make changes to this bug.