Bug 8683

Summary: REGRESSION: imdb search button has "Submit" overlaid after going back
Product: WebKit Reporter: Daniele Metilli <daniele.metilli>
Component: FormsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2 Keywords: EasyFix, HasReduction, Regression
Version: 420+   
Hardware: Macintosh   
OS: OS X 10.4   
URL: http://imdb.com/title/tt0120907/
Attachments:
Description Flags
patch that addresses this bug and also a poor data structure for form restore adele: review+

Description Daniele Metilli 2006-05-01 09:18:42 PDT
This bug has previously been reported in the comments of bug 7691.

How to reproduce this:

1 - Go to http://imdb.com/title/tt0120907/
2 - Click on "David Cronenberg".
3 - Go back using Safari's back button.
4 - The search button is rendered incorrectly.

This happens in TOT (r14126).

Darin said about this:

The new bug doesn't have to do with the button rendering itself, but rather
with the way form data is saved and restored. Apparently a null is saved, but
an empty string is restored, or vice versa.

The fix will be to change HTMLInputElement::state and
HTMLInputElement::restoreState so they can distinguish a state of null string
from a state of empty string, which should be straightforward.
Comment 1 Darin Adler 2006-05-04 08:34:57 PDT
Created attachment 8103 [details]
patch that addresses this bug and also a poor data structure for form restore
Comment 2 Adele Peterson 2006-05-04 21:17:49 PDT
Comment on attachment 8103 [details]
patch that addresses this bug and also a poor data structure for form restore

I think it would be worth checking in a manual test for this.