Bug 86788

Summary:

Plug-ins blacklist mechanism can tell clients about plug-in with null identifier

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sullivan: review+

Description Anders Carlsson 2012-05-17 17:06:01 PDT

Plug-ins blacklist mechanism can tell clients about plug-in with null identifier

Comment 1 Anders Carlsson 2012-05-17 17:08:36 PDT

Created attachment 142591 [details]
Patch

Comment 2 Anders Carlsson 2012-05-17 17:12:17 PDT

Committed r117516: <http://trac.webkit.org/changeset/117516>

Comment 3 Philippe Normand 2012-05-17 21:36:03 PDT

Comment on attachment 142591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142591&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3639
> -    m_loaderClient.didBlockInsecurePluginVersion(this, mimeType, pluginIdentifier, pluginVersion);
> +    m_loaderClient.didBlockInsecurePluginVersion(this, newMimeType, pluginIdentifier, pluginVersion);

newMimeType is guarded by PLATFORM(MAC) above... This patch broke GTK and Qt builds...

Comment 4 Philippe Normand 2012-05-17 21:44:40 PDT

Build fix in http://trac.webkit.org/changeset/117539.
Can you please care about the EWS next time before landing? FYI, purple bubble means patch didn't apply correctly (=> EWS did not build the patch).

Comment 5 Philippe Normand 2012-05-17 21:47:27 PDT

Actually at least the GTK EWS did build the patch and failed at it. So... no excuse :)