Bug 86788

Summary: Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sullivan: review+

Anders Carlsson
Reported 2012-05-17 17:06:01 PDT
Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
Attachments
Patch (4.90 KB, patch)
2012-05-17 17:08 PDT, Anders Carlsson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-05-17 17:08:36 PDT
Created attachment 142591 [details] Patch
Anders Carlsson
Comment 2 2012-05-17 17:12:17 PDT
Committed r117516: <http://trac.webkit.org/changeset/117516>
Philippe Normand
Comment 3 2012-05-17 21:36:03 PDT
Comment on attachment 142591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142591&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3639 > - m_loaderClient.didBlockInsecurePluginVersion(this, mimeType, pluginIdentifier, pluginVersion); > + m_loaderClient.didBlockInsecurePluginVersion(this, newMimeType, pluginIdentifier, pluginVersion); newMimeType is guarded by PLATFORM(MAC) above... This patch broke GTK and Qt builds...
Philippe Normand
Comment 4 2012-05-17 21:44:40 PDT
Build fix in http://trac.webkit.org/changeset/117539. Can you please care about the EWS next time before landing? FYI, purple bubble means patch didn't apply correctly (=> EWS did not build the patch).
Philippe Normand
Comment 5 2012-05-17 21:47:27 PDT
Actually at least the GTK EWS did build the patch and failed at it. So... no excuse :)
Note You need to log in before you can comment on or make changes to this bug.