Bug 86788 - Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
Summary: Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 17:06 PDT by Anders Carlsson
Modified: 2012-05-17 21:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2012-05-17 17:08 PDT, Anders Carlsson 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-05-17 17:06:01 PDT 
Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
Comment 1 Anders Carlsson 2012-05-17 17:08:36 PDT 
Created attachment 142591 [details]
Patch
Comment 2 Anders Carlsson 2012-05-17 17:12:17 PDT 
Committed r117516: <http://trac.webkit.org/changeset/117516>
Comment 3 Philippe Normand 2012-05-17 21:36:03 PDT 
Comment on attachment 142591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142591&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3639
> -    m_loaderClient.didBlockInsecurePluginVersion(this, mimeType, pluginIdentifier, pluginVersion);
> +    m_loaderClient.didBlockInsecurePluginVersion(this, newMimeType, pluginIdentifier, pluginVersion);

newMimeType is guarded by PLATFORM(MAC) above... This patch broke GTK and Qt builds...
Comment 4 Philippe Normand 2012-05-17 21:44:40 PDT 
Build fix in http://trac.webkit.org/changeset/117539.
Can you please care about the EWS next time before landing? FYI, purple bubble means patch didn't apply correctly (=> EWS did not build the patch).
Comment 5 Philippe Normand 2012-05-17 21:47:27 PDT 
Actually at least the GTK EWS did build the patch and failed at it. So... no excuse :)