Bug 86778

Summary: Linux amd64 platform reported as i686
Product: WebKit Reporter: Michael Moss <mmoss>
Component: New BugsAssignee: Michael Moss <mmoss>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Michael Moss
Reported 2012-05-17 15:04:52 PDT
Linux amd64 platform reported as i686
Attachments
Patch (1.61 KB, patch)
2012-05-17 15:20 PDT, Michael Moss 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2012-05-17 15:36 PDT, Michael Moss 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2012-05-17 16:03 PDT, Michael Moss 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.83 KB, patch)
2012-05-17 17:01 PDT, Michael Moss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Michael Moss
Comment 1 2012-05-17 15:20:57 PDT
Created attachment 142566 [details] Patch
WebKit Review Bot
Comment 2 2012-05-17 15:23:41 PDT
Attachment 142566 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Moss
Comment 3 2012-05-17 15:36:14 PDT
Created attachment 142570 [details] Patch
Tony Chang
Comment 4 2012-05-17 15:55:32 PDT
Comment on attachment 142570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142570&action=review LGTM. I'll wait for the ews bots to go green before setting cq+. > Source/WebCore/ChangeLog:7 > + http://code.google.com/p/chromium/issues/detail?id=128167 > + > + Reviewed by NOBODY (OOPS!). Nit: You could add some text here about this code pre-dating the code in WebCore to detect this at runtime.
Michael Moss
Comment 5 2012-05-17 16:03:08 PDT
Created attachment 142578 [details] Patch
Michael Moss
Comment 6 2012-05-17 17:01:16 PDT
Created attachment 142590 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-05-17 17:01:51 PDT
Comment on attachment 142590 [details] Patch for landing Rejecting attachment 142590 [details] from commit-queue. mmoss@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 8 2012-05-17 18:40:09 PDT
Comment on attachment 142590 [details] Patch for landing Clearing flags on attachment: 142590 Committed r117524: <http://trac.webkit.org/changeset/117524>
WebKit Review Bot
Comment 9 2012-05-17 18:40:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.