Bug 86770 – Move logic of checking whether a frame needs to be flattened to RenderFrameBase.

• Component: Layout and Rendering
• Status: RESOLVED INVALID

[alan]

So that flattening checking code can somewhat be shared between frameset and iframe. That would eliminate the need of early return and mimicking non-flattening layout case in RenderFrameBase::layoutWithFlattening(), which can get (and is) out of sync in case of iframe layouting.
See below.

RenderFrameBase::layoutWithFlattening(...)
{
...
    if (!width() || !height() || !childRoot) {
        updateWidgetPosition();
        if (childFrameView)
            childFrameView->layout();
        setNeedsLayout(false);
        return;
...
}

vs.

RenderIFrame::layout() 
{
...
    RenderPart::layout();

    m_overflow.clear();
    addVisualEffectOverflow();
    updateLayerTransform();
    setNeedsLayout(false);
...
}

[Ahmad Saleem]

https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687 <- Frame Flattening code is gone, should we close this? @Alan