Bug 86755

Summary: [Chromium] Move cookieJar to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-05-17 11:09:39 PDT
[Chromium] Move cookieJar to Platform.h
Attachments
Patch (14.52 KB, patch)
2012-05-17 11:10 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (8.63 KB, patch)
2012-05-22 14:50 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (14.57 KB, patch)
2012-05-22 14:52 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-17 11:10:29 PDT
Created attachment 142507 [details] Patch
WebKit Review Bot
Comment 2 2012-05-17 11:13:54 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-05-21 15:45:36 PDT
Comment on attachment 142507 [details] Patch Rejecting attachment 142507 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nk #2 succeeded at 69 (offset -5 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h.rej patching file Source/WebKit/chromium/src/PlatformSupport.cpp Hunk #1 succeeded at 50 with fuzz 2. Hunk #2 succeeded at 93 with fuzz 2. Hunk #3 succeeded at 135 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12739596
Mark Pilgrim (Google)
Comment 4 2012-05-22 14:50:39 PDT
Created attachment 143369 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-05-22 14:52:59 PDT
Created attachment 143370 [details] Patch
WebKit Review Bot
Comment 6 2012-05-22 16:40:37 PDT
Comment on attachment 143370 [details] Patch Clearing flags on attachment: 143370 Committed r118080: <http://trac.webkit.org/changeset/118080>
WebKit Review Bot
Comment 7 2012-05-22 16:40:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.