Summary: | REGRESSION (r117428): WebKit API/SPI was removed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cruz.ryan, eric, gyuyoung.kim, informatika, jberlin, mitz, smkolins, svetloslav | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 86704 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2012-05-17 09:30:36 PDT
Created attachment 142489 [details] ROLLOUT of r117428 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Looks like the attached patch is bogus. This will need to be done by hand. The reason that this broke the Safari build is that it removed API / SPI that Safari was using. Reverted r117428 in <http://trac.webkit.org/r117460>. *** Bug 86735 has been marked as a duplicate of this bug. *** *** Bug 86737 has been marked as a duplicate of this bug. *** *** Bug 86729 has been marked as a duplicate of this bug. *** *** Bug 86740 has been marked as a duplicate of this bug. *** Comment on attachment 142489 [details] ROLLOUT of r117428 View in context: https://bugs.webkit.org/attachment.cgi?id=142489&action=review > Source/WebCore/ChangeLog:16 > +2012-05-17 Pavel Feldman <pfeldman@chromium.org> This changelog loks wrong, but otherwise the patch looks fine. I wonder why the sherrif-bot goofed here. Thank you mitz. |