Bug 86718

Summary: Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Ilya Tikhonovsky 2012-05-17 04:23:15 PDT 
The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array.
Due to nature of nodeIndex values the original array was sparsed.

RESULT heap-snapshot: _calculateObjectToWindowDistance= 768 ms
vs
RESULT heap-snapshot: _calculateObjectToWindowDistance= 110 ms
Comment 1 Ilya Tikhonovsky 2012-05-17 04:25:12 PDT 
Created attachment 142451 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-17 04:48:21 PDT 
Comment on attachment 142451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142451&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:942
> +                         ? nodes[nodeIndex + firstEdgeIndexOffset + nodeFieldCount]

Please revert change in this line.
Comment 3 Ilya Tikhonovsky 2012-05-17 05:47:23 PDT 
Committed r117437: <http://trac.webkit.org/changeset/117437>