Summary: | Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | sam <dsam2912> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Created attachment 142428 [details]
Patch
Attachment 142428 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 142447 [details]
Patch
(In reply to comment #3) > Created an attachment (id=142447) [details] > Patch The patch is for option 2 from the attachment(screen shot) in Description. Is it ok? Comment on attachment 142447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review > Source/WebCore/inspector/front-end/inspector.css:2150 > + background-color: rgba(56, 121, 217, 0.2); Is alpha channel 0.1(which matches elements tree selection) too blind ? (In reply to comment #5) > (From update of attachment 142447 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review > > > Source/WebCore/inspector/front-end/inspector.css:2150 > > + background-color: rgba(56, 121, 217, 0.2); > > Is alpha channel 0.1(which matches elements tree selection) too blind ? Ya i tried that, but was coming out too blind. Comment on attachment 142447 [details] Patch Clearing flags on attachment: 142447 Committed r117445: <http://trac.webkit.org/changeset/117445> All reviewed patches have been landed. Closing bug. |
Created attachment 142423 [details] screen shot hovering effect on breakpoints in Breakpoints pane. Hover on a breakpoint in Breakpoints-pane does not get differentiated with other breakpoints in list. Have attached the screen shot with some options. Will upload the patch.