Bug 86708

Summary: Add an assertion to make sure that visited node is not active insertion point.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
add an assertion
none
Patch for landing none

Description Hayato Ito 2012-05-16 22:58:46 PDT
Now InsertionPoint has isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010

We can add an assertion to ComposedShadowTreeWalker using that function.
Comment 1 Hayato Ito 2012-05-16 23:04:37 PDT
Created attachment 142418 [details]
add an assertion
Comment 2 Eric Seidel (no email) 2012-05-17 03:28:39 PDT
Comment on attachment 142418 [details]
add an assertion

ok.
Comment 3 WebKit Review Bot 2012-05-17 04:07:02 PDT
Comment on attachment 142418 [details]
add an assertion

Rejecting attachment 142418 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12724121
Comment 4 Hayato Ito 2012-05-17 19:16:18 PDT
Created attachment 142610 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-05-17 20:23:59 PDT
Comment on attachment 142610 [details]
Patch for landing

Clearing flags on attachment: 142610

Committed r117534: <http://trac.webkit.org/changeset/117534>
Comment 6 WebKit Review Bot 2012-05-17 20:24:03 PDT
All reviewed patches have been landed.  Closing bug.