Bug 86708

Summary: Add an assertion to make sure that visited node is not active insertion point.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
add an assertion
none
Patch for landing none

Hayato Ito
Reported 2012-05-16 22:58:46 PDT
Now InsertionPoint has isActive() member function. https://bugs.webkit.org/show_bug.cgi?id=82010 We can add an assertion to ComposedShadowTreeWalker using that function.
Attachments
add an assertion (1.85 KB, patch)
2012-05-16 23:04 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.90 KB, patch)
2012-05-17 19:16 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-05-16 23:04:37 PDT
Created attachment 142418 [details] add an assertion
Eric Seidel (no email)
Comment 2 2012-05-17 03:28:39 PDT
Comment on attachment 142418 [details] add an assertion ok.
WebKit Review Bot
Comment 3 2012-05-17 04:07:02 PDT
Comment on attachment 142418 [details] add an assertion Rejecting attachment 142418 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12724121
Hayato Ito
Comment 4 2012-05-17 19:16:18 PDT
Created attachment 142610 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-05-17 20:23:59 PDT
Comment on attachment 142610 [details] Patch for landing Clearing flags on attachment: 142610 Committed r117534: <http://trac.webkit.org/changeset/117534>
WebKit Review Bot
Comment 6 2012-05-17 20:24:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.