Bug 86684

Summary:

[chromium] Use overloaded printBegin() webkit api to support auto fit to page functionality

Product:

WebKit

Reporter:

kmadhusu <kmadhusu>

Component:

Printing

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, jamesr, rniwa, tkent, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

86938

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

kmadhusu

Reported 2012-05-16 15:25:59 PDT

This is a follow up CL of bug 84312 to remove the unused printBegin() function.

Attachments
Patch (10.19 KB, patch) 2012-05-16 15:38 PDT, kmadhusu	no flags	Details Formatted Diff Diff
Patch (10.19 KB, patch) 2012-05-20 12:13 PDT, kmadhusu	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

kmadhusu

Comment 1 2012-05-16 15:38:30 PDT

Created attachment 142357 [details] Patch

WebKit Review Bot

Comment 2 2012-05-16 15:42:27 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

WebKit Review Bot

Comment 3 2012-05-16 16:28:14 PDT

Comment on attachment 142357 [details] Patch Attachment 142357 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12722282

kmadhusu

Comment 4 2012-05-16 17:11:43 PDT

You can find webkit_glue.cc changes @http://codereview.chromium.org/10168013/.

WebKit Review Bot

Comment 5 2012-05-18 22:19:39 PDT

Comment on attachment 142357 [details] Patch Clearing flags on attachment: 142357 Committed r117675: <http://trac.webkit.org/changeset/117675>

WebKit Review Bot

Comment 6 2012-05-18 22:19:43 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 7 2012-05-19 00:06:12 PDT

Re-opened since this is blocked by 86938

Ryosuke Niwa

Comment 8 2012-05-19 00:08:58 PDT

This patch broke builds: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/7967/steps/compile/logs/stdio In file included from /b/build/slave/Mac_Builder__dbg_/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:162: public/WebPrintParams.h:67:30: error: field is uninitialized when used here [-Werror,-Wuninitialized] , printScalingOption(printScalingOption) { } ^ 1 error generated. You can't initialize member variables by themselves. Please use different names.

Ryosuke Niwa

Comment 9 2012-05-19 19:18:54 PDT

(In reply to comment #8) > Please use different names. Ugh... I mean different *values*.

kmadhusu

Comment 10 2012-05-20 12:13:17 PDT

Created attachment 142912 [details] Patch

kmadhusu

Comment 11 2012-05-20 15:14:05 PDT

oops. It was a typo. Fixed the issue and uploaded a new patch for review.

kmadhusu

Comment 12 2012-05-21 09:40:07 PDT

fishd@: My previous patch was rolled out due to a compile error. Can you review the new patch? Thanks.

WebKit Review Bot

Comment 13 2012-05-22 15:10:28 PDT

Comment on attachment 142912 [details] Patch Clearing flags on attachment: 142912 Committed r118062: <http://trac.webkit.org/changeset/118062>

WebKit Review Bot

Comment 14 2012-05-22 15:10:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.