Summary: | [chromium] Use overloaded printBegin() webkit api to support auto fit to page functionality | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | kmadhusu <kmadhusu> | ||||||
Component: | Printing | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, rniwa, tkent, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 86938 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
kmadhusu
2012-05-16 15:25:59 PDT
Created attachment 142357 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 142357 [details] Patch Attachment 142357 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12722282 You can find webkit_glue.cc changes @http://codereview.chromium.org/10168013/. Comment on attachment 142357 [details] Patch Clearing flags on attachment: 142357 Committed r117675: <http://trac.webkit.org/changeset/117675> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 86938 This patch broke builds: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/7967/steps/compile/logs/stdio In file included from /b/build/slave/Mac_Builder__dbg_/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:162: public/WebPrintParams.h:67:30: error: field is uninitialized when used here [-Werror,-Wuninitialized] , printScalingOption(printScalingOption) { } ^ 1 error generated. You can't initialize member variables by themselves. Please use different names. (In reply to comment #8) > Please use different names. Ugh... I mean different *values*. Created attachment 142912 [details]
Patch
oops. It was a typo. Fixed the issue and uploaded a new patch for review. fishd@: My previous patch was rolled out due to a compile error. Can you review the new patch? Thanks. Comment on attachment 142912 [details] Patch Clearing flags on attachment: 142912 Committed r118062: <http://trac.webkit.org/changeset/118062> All reviewed patches have been landed. Closing bug. |