Bug 86638

Summary: Bump the version number on the WKBundlePageLoaderClient
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: dinu.jacob, gustavo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
mitz: review-
Patch v2 - Now with more traits mitz: review+, gustavo: commit-queue-

Brady Eidson
Reported 2012-05-16 08:54:00 PDT
Bump the version number on the WKBundlePageLoaderClient
Attachments
Patch v1 (1.87 KB, patch)
2012-05-16 08:56 PDT, Brady Eidson 		mitz: review-
DetailsFormatted DiffDiff
Patch v2 - Now with more traits (2.47 KB, patch)
2012-05-16 09:03 PDT, Brady Eidson 		mitz: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-05-16 08:56:30 PDT
Created attachment 142273 [details] Patch v1
Brady Eidson
Comment 2 2012-05-16 08:59:41 PDT
Working on the traits, also.
Brady Eidson
Comment 3 2012-05-16 09:03:31 PDT
Created attachment 142276 [details] Patch v2 - Now with more traits Still waiting on my build to catch up, won't land before that.
Gustavo Noronha (kov)
Comment 4 2012-05-16 09:10:02 PDT
Comment on attachment 142276 [details] Patch v2 - Now with more traits Attachment 142276 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12708584
Build Bot
Comment 5 2012-05-16 09:10:43 PDT
Comment on attachment 142276 [details] Patch v2 - Now with more traits Attachment 142276 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12723049
Build Bot
Comment 6 2012-05-16 09:19:15 PDT
Comment on attachment 142276 [details] Patch v2 - Now with more traits Attachment 142276 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12716297
Brady Eidson
Comment 7 2012-05-16 09:30:37 PDT
http://trac.webkit.org/changeset/117301
Brady Eidson
Comment 8 2012-05-16 09:30:59 PDT
The EWS failures were things I picked up locally and resolved before landing. Sorry for the noise.
Dinu Jacob
Comment 9 2012-05-16 09:49:34 PDT
Is there a general guideline on when the version should be bumped up when a new callback is added?
Brady Eidson
Comment 10 2012-05-16 10:27:27 PDT
(In reply to comment #9) > Is there a general guideline on when the version should be bumped up when a new callback is added? Not in cases like this one. The folks impacted in this case are trying to come up with a better process going forward.
Note You need to log in before you can comment on or make changes to this bug.