Bug 86622

Summary: NEON intrinsic should be used with arithmetic mode of composite filter
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS test
none
EWS test
none
patch zimmermann: review+

Zoltan Herczeg
Reported 2012-05-16 06:56:08 PDT
Let's do it
Attachments
EWS test (20.74 KB, patch)
2012-05-16 06:56 PDT, Zoltan Herczeg 		no flags
DetailsFormatted DiffDiff
EWS test (20.99 KB, patch)
2012-05-16 07:00 PDT, Zoltan Herczeg 		no flags
DetailsFormatted DiffDiff
patch (22.52 KB, patch)
2012-05-16 23:50 PDT, Zoltan Herczeg 		zimmermann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2012-05-16 06:56:39 PDT
Created attachment 142245 [details] EWS test
Zoltan Herczeg
Comment 2 2012-05-16 07:00:22 PDT
Created attachment 142248 [details] EWS test Sorry, wrong patch before
WebKit Review Bot
Comment 3 2012-05-16 07:03:54 PDT
Attachment 142248 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zoltan Herczeg
Comment 4 2012-05-16 23:50:54 PDT
Created attachment 142424 [details] patch
Nikolas Zimmermann
Comment 5 2012-05-17 00:04:49 PDT
Comment on attachment 142424 [details] patch Wow, this looks much better, rs=me. I trust you that the intrinsics stuff is correct, can't really review that properly.
Zoltan Herczeg
Comment 6 2012-05-17 02:12:28 PDT
Thanks for the review. Landed as trac.webkit.org/changeset/117418
Note You need to log in before you can comment on or make changes to this bug.