Bug 86615

Summary: [EFL][DRT] EFL DRT needs deletebutton controller
Product: WebKit Reporter: Mariusz Grzegorczyk <mariusz.g>
Component: WebKit EFLAssignee: Mariusz Grzegorczyk <mariusz.g>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cshu, g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco, rniwa, sw0524.lee, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixing delete button implementation cshu: review-, rakuco: commit-queue-

Mariusz Grzegorczyk
Reported 2012-05-16 06:13:11 PDT
Layout tests which fails because of it: editing/deleting/5408255.html editing/deleting/regional-indicators.html
Attachments
Fixing delete button implementation (7.42 KB, patch)
2012-06-11 04:41 PDT, Mariusz Grzegorczyk 		cshu: review-
rakuco: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mariusz Grzegorczyk
Comment 1 2012-06-11 04:41:46 PDT
Created attachment 146832 [details] Fixing delete button implementation
Chris Dumez
Comment 2 2012-06-12 05:08:23 PDT
Comment on attachment 146832 [details] Fixing delete button implementation LGTM.
Gyuyoung Kim
Comment 3 2012-06-12 18:08:05 PDT
Comment on attachment 146832 [details] Fixing delete button implementation Ok, looks good to me.
Grzegorz Czajkowski
Comment 4 2012-06-13 03:53:05 PDT
LGTM. CC'ing reviewers.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-07-06 21:00:58 PDT
Comment on attachment 146832 [details] Fixing delete button implementation View in context: https://bugs.webkit.org/attachment.cgi?id=146832&action=review Sorry for being late to the party, but I object to this. The comment the unskipped test deletionUI-single-instance.html summarizes what this whole feature seems to boil down to: something Apple-specific we should not have to worry about. The Qt and Chromium ports only implement shouldShowDeleteInterface for testing purposes, and the only port besides the Apple ones that emits a signal for end users about this is the GTK+ one, and even there it does not seem to be properly documented. > Source/WebCore/ChangeLog:11 > + * platform/efl/SharedBufferEfl.cpp: > + (WebCore::SharedBuffer::createWithContentsOfFile): Fix creation of shared buffer from image This has been fixed in r121254. > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:66 > + return element->getAttribute(HTMLNames::classAttr) == "needsDeletionUI"; This seems to be an Apple-specific attribute.
Ryosuke Niwa
Comment 6 2013-02-11 16:36:50 PST
I'm moving these tests into platform/mac.
Note You need to log in before you can comment on or make changes to this bug.