Summary: | [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||
Component: | Tools / Tests | Assignee: | Shawn Singh <shawnsingh> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, enne, fishd, jamesr, tkent, tkent+wkapi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-05-16 00:42:27 PDT
Created attachment 142202 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. The failure is caused by the assertion at WebPrivateOwnPtr::~WebPrivateOwnPtr(). Kent-san, could you take a look? Comment on attachment 142202 [details]
Patch
ok
(In reply to comment #4) > (From update of attachment 142202 [details]) > ok Thanks! Comment on attachment 142202 [details] Patch Clearing flags on attachment: 142202 Committed r117257: <http://trac.webkit.org/changeset/117257> All reviewed patches have been landed. Closing bug. Thank you for fixing this, I apologize you had to do it on my behalf Comment on attachment 142202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142202&action=review > Source/Platform/chromium/public/WebTransformationMatrix.h:54 > + ~WebTransformationMatrix(); we typically have this declared inline and call a exported reset() function. this class is still in a bit of flux, though (it doesn't have proper exports yet, for instance) |