Bug 86567

Summary: Add new build slave for EFL port
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric, lforschler, rniwa, webkit.review.bot, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-05-15 21:08:17 PDT
Add new build slave for EFL 32-bit linux build. I verify that this build slave works according to http://trac.webkit.org/wiki/BuildBot guidance. Though I wanted to run Build and Test bot, unfortunately, I could run build bot because of PC hardware performance. However, when I have more powerful PC, I will change this with Build and Test bot in future.
Attachments
Patch (3.49 KB, patch)
2012-05-15 21:20 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-05-15 21:20:24 PDT
Created attachment 142139 [details] Patch
Gyuyoung Kim
Comment 2 2012-05-15 21:45:49 PDT
CC'ing Ryosuke.
Eric Seidel (no email)
Comment 3 2012-05-16 18:12:08 PDT
I don't know who reviews these these days. I used to use aroben for this sort of thing. :)
WebKit Review Bot
Comment 4 2012-05-16 19:18:08 PDT
Comment on attachment 142139 [details] Patch Clearing flags on attachment: 142139 Committed r117380: <http://trac.webkit.org/changeset/117380>
WebKit Review Bot
Comment 5 2012-05-16 19:18:13 PDT
All reviewed patches have been landed. Closing bug.
Gyuyoung Kim
Comment 6 2012-05-16 19:49:06 PDT
William, Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted.
Ryosuke Niwa
Comment 7 2012-05-16 20:12:23 PDT
(In reply to comment #6) > William, > > Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted. Maybe there's a syntax error? Did you confirm that your config file is correct by loading it on your local machine?
Gyuyoung Kim
Comment 8 2012-05-16 21:46:03 PDT
(In reply to comment #7) > (In reply to comment #6) > > William, > > > > Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted. > > Maybe there's a syntax error? Did you confirm that your config file is correct by loading it on your local machine? I just tested it on my local buildbot. You can it at below link. http://50.17.188.232:8710/waterfall?category=EFL Do I need to modify other configuration files except for config.json ?
William Siegrist
Comment 9 2012-05-17 06:48:35 PDT
You also need to request a password for the slave. The restart will fail if you mention a slave with no password in the config. I'll send the password details to Gyuyoung in email. The slave has been added and the master restarted.
Note You need to log in before you can comment on or make changes to this bug.