Bug 86564

Summary: Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: crogers, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Raymond Toy
Reported 2012-05-15 20:22:42 PDT
The debugging prints for DEBUG_AUDIONODE_REFERENCES use printf, but it's nicer to fprintf instead so that the debugging messages aren't all buffered up and printed whenever stdio decides to output the buffer. It makes it easier to follow things as they happen.
Attachments
Patch (3.74 KB, patch)
2012-06-19 02:59 PDT, Andrei Poenaru 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2012-06-19 04:23 PDT, Andrei Poenaru 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Poenaru
Comment 1 2012-06-19 02:59:09 PDT
Created attachment 148297 [details] Patch
WebKit Review Bot
Comment 2 2012-06-19 03:05:07 PDT
Attachment 148297 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrei Poenaru
Comment 3 2012-06-19 04:23:19 PDT
Created attachment 148310 [details] Patch
Csaba Osztrogonác
Comment 4 2012-06-19 05:32:42 PDT
Comment on attachment 148310 [details] Patch LGTM, r=me.
WebKit Review Bot
Comment 5 2012-06-19 06:59:34 PDT
Comment on attachment 148310 [details] Patch Clearing flags on attachment: 148310 Committed r120707: <http://trac.webkit.org/changeset/120707>
WebKit Review Bot
Comment 6 2012-06-19 06:59:40 PDT
All reviewed patches have been landed. Closing bug.
Raymond Toy
Comment 7 2012-06-19 10:18:48 PDT
(In reply to comment #4) > (From update of attachment 148310 [details]) > LGTM, r=me. A bit too late, but doesn't AudioNode.cpp need to include <stdio.h> when DEBUG_AUDIONODE_REFERENCES is non-zero? I think I needed this on linux.
Note You need to log in before you can comment on or make changes to this bug.