Bug 86556

Summary: [Worker] Web Worker lacks test for posting structured data message.
Product: WebKit Reporter: Li Yin <li.yin>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dimich, levin, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Li Yin
Reported 2012-05-15 18:22:09 PDT
From http://www.w3.org/TR/2012/CR-workers-20120501/#communicating-with-a-dedicated-worker Structured data can be sent over this communication channel. worker.postMessage({ operation: 'find-edges', input: buffer, // an ArrayBuffer object threshold: 0.6, }, [buffer]);
Attachments
Patch (4.08 KB, patch)
2012-05-15 18:39 PDT, Li Yin 		no flags
DetailsFormatted DiffDiff
Patch (4.11 KB, patch)
2012-05-15 19:22 PDT, Li Yin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Li Yin
Comment 1 2012-05-15 18:39:02 PDT
Created attachment 142121 [details] Patch
David Levin
Comment 2 2012-05-15 18:44:19 PDT
Comment on attachment 142121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142121&action=review Seems ok. Just a few nits to fix up. > LayoutTests/fast/workers/resources/worker-structure-message.js:7 > + var buf = new ArrayBuffer(20); Why is this allocated here? I don't see it being used. > LayoutTests/fast/workers/worker-structure-message.html:5 > +Should print "DONE" when done.</p> On success, you should see...
Li Yin
Comment 3 2012-05-15 19:22:04 PDT
Created attachment 142129 [details] Patch
Li Yin
Comment 4 2012-05-15 19:24:40 PDT
(In reply to comment #2) > (From update of attachment 142121 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142121&action=review > > Seems ok. Just a few nits to fix up. > > > LayoutTests/fast/workers/resources/worker-structure-message.js:7 > > + var buf = new ArrayBuffer(20); > > Why is this allocated here? I don't see it being used. Sorry, forget to delete. Now it has been deleted. > > > LayoutTests/fast/workers/worker-structure-message.html:5 > > +Should print "DONE" when done.</p> > > On success, you should see... Add the related log. Thanks for your review.
David Levin
Comment 5 2012-05-15 20:00:08 PDT
You can set cq? when you set r? and save a step :) for everyone.
Li Yin
Comment 6 2012-05-15 20:02:47 PDT
(In reply to comment #5) > You can set cq? when you set r? and save a step :) for everyone. :) Thanks for your reminding.
WebKit Review Bot
Comment 7 2012-05-15 22:35:49 PDT
Comment on attachment 142129 [details] Patch Clearing flags on attachment: 142129 Committed r117220: <http://trac.webkit.org/changeset/117220>
WebKit Review Bot
Comment 8 2012-05-15 22:35:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.