Bug 86526

Summary:

initial flex value should be 1 1 auto

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

Layout and Rendering

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, eric, macpherson, menard, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62048

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cq-02	none
Patch for landing	none

Tony Chang

Reported 2012-05-15 14:21:49 PDT

It's currently 0 0 auto. This changed in a recent F2F. The desire is for flex items to flex by default.

Attachments
Patch (71.06 KB, patch) 2012-05-31 13:56 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cq-02 (495.12 KB, application/zip) 2012-05-31 17:52 PDT, WebKit Review Bot	no flags	Details
Patch for landing (76.36 KB, patch) 2012-05-31 19:18 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2012-05-18 10:36:42 PDT

Note: The implications for omitted negative flex are still being discussed: http://wiki.csswg.org/topics/css3-flexbox-default-shrink-when-grow-is-0

Tony Chang

Comment 2 2012-05-31 13:56:39 PDT

Created attachment 145151 [details] Patch

WebKit Review Bot

Comment 3 2012-05-31 17:52:42 PDT

Comment on attachment 145151 [details] Patch Rejecting attachment 145151 [details] from commit-queue. New failing tests: fast/multicol/span/clone-flexbox.html transitions/flex-transitions.html Full output: http://queues.webkit.org/results/12868356

WebKit Review Bot

Comment 4 2012-05-31 17:52:46 PDT

Created attachment 145182 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Tony Chang

Comment 5 2012-05-31 19:18:00 PDT

Created attachment 145195 [details] Patch for landing

Tony Chang

Comment 6 2012-05-31 19:19:18 PDT

The render tree results for fast/multicol/span/clone-flexbox.html might not be exactly correct for some platforms. I tried to guess the size based on how it turned out in Chromium. Feel free to rebaseline if the size of the anonymous RenderBlock is wrong.

WebKit Review Bot

Comment 7 2012-05-31 20:33:07 PDT

Comment on attachment 145195 [details] Patch for landing Clearing flags on attachment: 145195 Committed r119191: <http://trac.webkit.org/changeset/119191>

WebKit Review Bot

Comment 8 2012-05-31 20:33:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.