Summary: | Implement run-in remove child cases. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Abhishek Arya <inferno> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, esprehn+autocc, glenn, hyatt, igor.oliveira, jchaffraix, mitz, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 93304 | ||||||||
Attachments: |
|
Description
Abhishek Arya
2012-05-15 13:48:43 PDT
Note that the implementation was still missing before http://trac.webkit.org/changeset/117482. Created attachment 200915 [details]
Patch
Proposed patch.
Comment on attachment 200915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200915&action=review > Source/WebCore/rendering/RenderBlock.cpp:2006 > - destroyRunIn(oldRunIn); > > // Add the run-in block as our previous sibling. > parent()->addChild(newRunIn, this); > + destroyRunIn(oldRunIn); What's going on here? Seems worth a comment in the changelog at least! Created attachment 201437 [details]
Patch
Proposed patch.
Comment on attachment 201437 [details]
Patch
r=me
Comment on attachment 201437 [details] Patch Clearing flags on attachment: 201437 Committed r150155: <http://trac.webkit.org/changeset/150155> All reviewed patches have been landed. Closing bug. |