Summary: | Add support for private names | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||||||||||||||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | arv, dglazkov, rakuco, tmpsantos, vestbo, webkit.review.bot | ||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Attachments: |
|
Description
Gavin Barraclough
2012-05-15 12:30:02 PDT
Created attachment 142034 [details]
Fix
No performance impact.
Attachment 142034 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/interpreter/Interpreter.cpp:49: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/NameConstructor.h:29: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:54: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/JSGlobalObject.cpp:56: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/JSGlobalObject.cpp:66: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/NameConstructor.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 7 in 62 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 142034 [details]
Fix
Add a test for for-in enumeration with a private name -- I couldn't see anything that would prevent optimised for-in from observing the private name.
(In reply to comment #3) > (From update of attachment 142034 [details]) > Add a test for for-in enumeration with a private name -- I couldn't see anything that would prevent optimised for-in from observing the private name. Will do - cheers oliver. Comment on attachment 142034 [details] Fix Attachment 142034 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12701562 Created attachment 142043 [details]
Add tests, fix style & Qt.
Comment on attachment 142034 [details] Fix Attachment 142034 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12715033 Comment on attachment 142043 [details] Add tests, fix style & Qt. Attachment 142043 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12706433 Comment on attachment 142043 [details] Add tests, fix style & Qt. Attachment 142043 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12705561 Comment on attachment 142034 [details] Fix Attachment 142034 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12704561 New failing tests: fast/js/names.html Created attachment 142075 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 142081 [details]
More Qt fixes
Comment on attachment 142081 [details] More Qt fixes Attachment 142081 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12703606 Created attachment 142124 [details]
More Qt fixes
Comment on attachment 142124 [details] More Qt fixes Attachment 142124 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12694913 New failing tests: fast/js/names.html Created attachment 142184 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 142124 [details] More Qt fixes Attachment 142124 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12716169 New failing tests: fast/js/names.html Created attachment 142199 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 143109 [details]
Skip test on chrome
Comment on attachment 143109 [details] Skip test on chrome Attachment 143109 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12738616 New failing tests: svg/custom/use-css-no-effect-on-shadow-tree.svg Created attachment 143137 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Fixed in r117859 After this patch, we are hitting an assertion on our EFL Debug Bot: ASSERTION FAILED: inherits(&s_info) Source/JavaScriptCore/runtime/NameInstance.h(63) : void JSC::NameInstance::finishCreation(JSC::JSGlobalData&) 1 0x7f4b7ae54dc0 JSC::NameInstance::finishCreation(JSC::JSGlobalData&) 2 0x7f4b7ae54d51 JSC::NameInstance::create(JSC::JSGlobalData&, JSC::Structure*, JSC::JSString*) 3 0x7f4b7ae54c7e 4 0x7f4b7ad6a786 cti_op_call_NotJSFunction 5 0x7f4b7ad65dad 6 0x7ffff37fcb90 (In reply to comment #23) > After this patch, we are hitting an assertion on our EFL Debug Bot: > > ASSERTION FAILED: inherits(&s_info) > Source/JavaScriptCore/runtime/NameInstance.h(63) : void JSC::NameInstance::finishCreation(JSC::JSGlobalData&) > 1 0x7f4b7ae54dc0 JSC::NameInstance::finishCreation(JSC::JSGlobalData&) > 2 0x7f4b7ae54d51 JSC::NameInstance::create(JSC::JSGlobalData&, JSC::Structure*, JSC::JSString*) > 3 0x7f4b7ae54c7e > 4 0x7f4b7ad6a786 cti_op_call_NotJSFunction > 5 0x7f4b7ad65dad > 6 0x7ffff37fcb90 Forgot to mention the test: fast/js/names.html Also fails on GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r117861%20(33465)/fast/js/names-crash-log.txt Ps.: I added this test to EFL test_expectations. |