Bug 86497

Summary: SVGElement::addEventListener has peculiar RefPtr usage
Product: WebKit Reporter: Darin Adler <darin>
Component: SVGAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, gustavo, philn, webkit.review.bot, xan.lopez, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2012-05-15 10:31:15 PDT
SVGElement::addEventListener has peculiar RefPtr usage
Attachments
Patch (2.50 KB, patch)
2012-05-15 10:32 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2012-05-22 22:27 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2012-05-15 10:32:01 PDT
Created attachment 141996 [details] Patch
Build Bot
Comment 2 2012-05-15 10:41:29 PDT
Comment on attachment 141996 [details] Patch Attachment 141996 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12684878
Andy Estes
Comment 3 2012-05-15 10:44:55 PDT
Comment on attachment 141996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review > Source/WebCore/svg/SVGElement.cpp:371 > return Node::addEventListener(eventType, listener, useCapture); As the EFL bot says, listener is used here > Source/WebCore/svg/SVGElement.cpp:373 > + RefPtr<EventListener> listener = prpListener; ...but isn't declared until here.
Andy Estes
Comment 4 2012-05-15 10:45:09 PDT
EWS, not EFL
Darin Adler
Comment 5 2012-05-15 13:01:51 PDT
Comment on attachment 141996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review >> Source/WebCore/svg/SVGElement.cpp:373 >> + RefPtr<EventListener> listener = prpListener; > > ...but isn't declared until here. Oops. Just need to move that up a few lines and say listener.release(). I’ll do that next time I’m at a computer with a source tree.
Darin Adler
Comment 6 2012-05-22 22:27:27 PDT
Created attachment 143462 [details] Patch
WebKit Review Bot
Comment 7 2012-05-24 11:02:39 PDT
Comment on attachment 143462 [details] Patch Clearing flags on attachment: 143462 Committed r118393: <http://trac.webkit.org/changeset/118393>
WebKit Review Bot
Comment 8 2012-05-24 11:02:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.