Bug 86469

Summary: Web Inspector: merge show navigator with pin navigator buttons.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] hidden
none
[IMAGE] pinned
none
[IMAGE] floating
none
Patch
none
Patch vsevik: review+

Pavel Feldman
Reported 2012-05-15 05:09:09 PDT
Small UI refactoring.
Attachments
[IMAGE] hidden (22.27 KB, image/png)
2012-05-15 05:12 PDT, Pavel Feldman 		no flags
Details
[IMAGE] pinned (28.93 KB, image/png)
2012-05-15 05:12 PDT, Pavel Feldman 		no flags
Details
[IMAGE] floating (39.85 KB, image/png)
2012-05-15 05:13 PDT, Pavel Feldman 		no flags
Details
Patch (17.48 KB, patch)
2012-05-15 05:15 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (18.93 KB, patch)
2012-05-15 05:34 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-05-15 05:12:28 PDT
Created attachment 141926 [details] [IMAGE] hidden
Pavel Feldman
Comment 2 2012-05-15 05:12:44 PDT
Created attachment 141927 [details] [IMAGE] pinned
Pavel Feldman
Comment 3 2012-05-15 05:13:03 PDT
Created attachment 141928 [details] [IMAGE] floating
Pavel Feldman
Comment 4 2012-05-15 05:15:07 PDT
Created attachment 141929 [details] Patch
Vsevolod Vlasov
Comment 5 2012-05-15 05:29:41 PDT
Comment on attachment 141929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141929&action=review > Source/WebCore/inspector/front-end/NavigatorOverlayController.js:102 > _pinNavigator: function() You sohuld unregister shortcut and remove mouse down listener here.
Pavel Feldman
Comment 6 2012-05-15 05:34:54 PDT
Created attachment 141932 [details] Patch
Pavel Feldman
Comment 7 2012-05-15 05:49:17 PDT
Committed r117055: <http://trac.webkit.org/changeset/117055>
Note You need to log in before you can comment on or make changes to this bug.