Bug 86466

Summary: Web Inspector: AdvancedSearchController is not stopped then view is hidden.
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
vsevik: review+
Patch
none
Patch none

Description eustas.bug 2012-05-15 04:48:23 PDT 
AdvancedSearchController overrides "wasHidden" method instead on "willHide".
Comment 1 eustas.bug 2012-05-15 04:53:36 PDT 
Created attachment 141918 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-05-15 05:13:44 PDT 
Comment on attachment 141918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

> Source/WebCore/ChangeLog:6
> +        AdvancedSearchController overrides "wasHidden" method instead of "willHide".

Please move this line below "Reviewed by".

> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
> +     * @override

We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).
Comment 3 eustas.bug 2012-05-15 06:15:57 PDT 
Comment on attachment 141918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
>> +     * @override
> 
> We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).

I've tried it before writing this annotation.
Compiler doesn't catch this error, that's no good. But we can hope it will do some day.

BUT this annotation not only for compiler, but also for developers, because it make code a way core clear.
Comment 4 eustas.bug 2012-05-15 06:20:12 PDT 
Comment on attachment 141918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

>> Source/WebCore/ChangeLog:6
>> +        AdvancedSearchController overrides "wasHidden" method instead of "willHide".
> 
> Please move this line below "Reviewed by".

OK
Comment 5 eustas.bug 2012-05-15 06:27:52 PDT 
Created attachment 141948 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-05-15 06:45:25 PDT 
Comment on attachment 141918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

>>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
>>> +     * @override
>> 
>> We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).
> 
> I've tried it before writing this annotation.
> Compiler doesn't catch this error, that's no good. But we can hope it will do some day.
> 
> BUT this annotation not only for compiler, but also for developers, because it make code a way core clear.

I don't think we should add compiler annotations for developers. We don't even add comments usually.
Please remove this for consistency.
Comment 7 eustas.bug 2012-05-15 07:35:20 PDT 
Created attachment 141966 [details]
Patch
Comment 8 WebKit Review Bot 2012-05-15 09:12:21 PDT 
Comment on attachment 141966 [details]
Patch

Clearing flags on attachment: 141966

Committed r117080: <http://trac.webkit.org/changeset/117080>
Comment 9 WebKit Review Bot 2012-05-15 09:12:26 PDT 
All reviewed patches have been landed.  Closing bug.