Bug 86462 – [EFL] The EFL port has no support for title directionality

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Chris Dumez]

The EFL port has no support for title directionality which is needed by:
  fast/dom/title-directionality.html
  fast/dom/title-directionality-removeChild.html

[Chris Dumez]

Created attachment 141942 [details]
Patch

This patch adds title text direction support to EFL port.

Note however that the tests cannot be unskipped yet because the title direction is not yet exposed via LayoutTestController.titleTextDirection.
I will implement this in a second patch to avoid ending up with a huge patch.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 141942 [details]
Patch

Looks good to me, but your Tools/ChangeLog is borked (it contains an extra entry below yours).

[Gyuyoung Kim]

Comment on attachment 141942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141942&action=review

As kubo, this patch looks good to me except for trivial style nit.

> Source/WebKit/efl/ewk/ewk_frame.h:155
> +    EWK_TEXT_DIRECTION_DEFAULT, // Natural writing direction ("inherit")

Style nit : We are using /**< instead of // in public header files.

[Chris Dumez]

Created attachment 142157 [details]
Patch

Take feedback into consideration.

[WebKit Review Bot]

Comment on attachment 142157 [details]
Patch

Rejecting attachment 142157 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
enderTree/efl/DumpRenderTreeChrome.cpp
Hunk #1 FAILED at 436.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp.rej
patching file Tools/EWebLauncher/main.c
Hunk #1 succeeded at 229 (offset 3 lines).
Hunk #2 succeeded at 256 (offset 3 lines).
Hunk #3 succeeded at 492 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12768230

[Chris Dumez]

Created attachment 143737 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143737 [details]
Patch for landing

Clearing flags on attachment: 143737

Committed r118329: <http://trac.webkit.org/changeset/118329>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.